Suggestions Code-Formatting

Welcome Guest! To enable all features please Login or Register.

#1
Kami
User Profile View All Posts by User View Thanks
Topic Starter
Rank: Newbie
50.6% (Neutral)

Posts: 1
Joined: 9/8/2014
Monday, September 8, 2014 12:31:04 PM

Hello There,

I've some Suggestions to make.

I have this code:


SELECT
	a.col1,
	a.col2,
	b.col1,
	c.col1
FROM
	table1 a
	INNER JOIN table2 b ON a.col1 = b.col1
	INNER JOIN table3 c on a.col1 = c.col1 AND b.col1 = c.col2
WHERE
	(
		a.col1 = '1'
		OR a.col1 = '2'
	)
	AND b.col2 = 3

Which is fine for me.
So i tried to format this from an unformatted form, with your formatter...

SELECT a.col1, a.col2, b.col1, c.col1 FROM table1 a INNER JOIN table2 b ON a.col1 = b.col1 INNER JOIN table3 c on a.col1 = c.col1 AND b.col1 = c.col2 WHERE (a.col1 = '1' OR a.col1 = '2') AND b.col2 = 3

and got this one:


SELECT
	a.col1,
	a.col2,
	b.col1,
	c.col1
FROM
	table1 a
	INNER JOIN table2 b ON a.col1 = b.col1
	INNER JOIN table3 c on a.col1 = c.col1 AND b.col1 = c.col2
WHERE
	(a.col1 = '1' OR a.col1 = '2') AND b.col2 = 3

So basicly it's fine. Except that if i have long tablenames and long joins with "AND" it will do a linebreak eventually and put it into the next line.
But i can't design the format for brackets and where statements. So it will not intend like i want it.

Next problem: brackets..
If you implement formatting please make sure that this:


WHERE
	(col1 = 1)
	AND 
	(
		(col2 = 2)
		OR (col2 = 3)
	)
	AND col3 = 4

doesn't get you this:


WHERE
	(
		col1 = 1
	)
	AND 
	(
		(
			col2 = 2
		)
		OR 
		(
			col2 = 3
		)
	)
	AND col3 = 4

That would be great! Thanks.

Wanna join the discussion?! Login to your SSMSBoost Add-in discussion board forum account or Register a new forum account

#2
Andrei
User Profile View All Posts by User View Thanks
Rank: Administration
100% (Exalted)

Posts: 398
Joined: 7/1/2012
Sunday, September 14, 2014 11:51:42 PM

Thanks, will be considered !

#3
GrahamWade
User Profile View All Posts by User View Thanks
Rank: Newbie
50.6% (Neutral)

Posts: 1
Joined: 9/29/2014
Monday, September 29, 2014 11:31:10 AM

I would like the option to indent "Try/ Catch" blocks and also "begin transaction"/ "commit transaction" blocks. The block indent doesn't seem to work for these.

#4
kuark7
User Profile View All Posts by User View Thanks
Rank: Newbie
51.2% (Neutral)

Posts: 2
Joined: 11/11/2014
Tuesday, November 11, 2014 6:23:23 PM

I agree with GrahamWade - it's problematic to not have options for formatting try-catch blocks. Would like the ability to indent them.

Thank you for considering.

#5
ikjeft01
User Profile View All Posts by User View Thanks
Rank: Newbie
51.2% (Neutral)

Posts: 2
Joined: 9/12/2014
Wednesday, November 12, 2014 8:28:29 PM

I agree with Kami on the nested AND/OR example.

I want to suggest that code like "WHERE userID in (1,2,3,4,5)" doesn't reformat to
"WHERE userID IN (
1
, 2
, 3
, 4
, 5
)
"

but it is ok for

"WHERE userName IN (
'Alice'
, 'Bob'
, 'Carol'
)
"

I realize this may not be incredibly easy to figure out, so maybe a configuration that determines how many characters each element in the "IN" clause must be before splitting lines (in other words, in my both examples, this value could be 2; the first example stays on one line because all the elements are less than or equal to 2, and the second example splits lines because at least one element is greater than 2).

Edited by user Wednesday, November 12, 2014 8:35:08 PM | Reason: Not specified

#6
NMGod
User Profile View All Posts by User View Thanks
Rank: Newbie
50.6% (Neutral)

Posts: 1
Joined: 6/29/2015
Monday, June 29, 2015 2:09:34 AM

I would also like some more formatting options around brackets.

The current formatting is horrible.

Important Information:

The SSMSBoost Add-in discussion board uses cookies. By continuing to browse this site, you are agreeing to our use of cookies. More Details Close